New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pane:get_current_working_dir returns url encoded text for non-ascii paths #4000
Comments
@@ -41,7 +41,9 @@
hostname = hostname:sub(1, dot - 1)
end
-- and extract the cwd from the uri
- cwd = cwd_uri:sub(slash)
+ cwd = cwd_uri:sub(slash):gsub("%%(%x%x)", function(hex)
+ return string.char(tonumber(hex, 16))
+ end)
table.insert(cells, cwd)
table.insert(cells, hostname) -- 外してみた。2023年2月20日 |
0f-0b, wez. |
I've looked into this a bit and my conclusion is:
In the meantime, I'm reclassifying this as an enhancement issue to make it simpler to do the things that most people will want to do with that url. |
Previously we'd return the Url string. Now we provide a Url object that provides access to the various elements of the Url. This will cause slightly breakage for folks that were treating it as a string in their status event handlers, for example. The docs have been updated to show how to run with both this new Url object and also continue to run on older versions of wezterm. They now also show how to manually percent decode the url for older versions of wezterm. refs: #4157 refs: #4000
In The Url object is documented at https://github.com/wez/wezterm/blob/b904ed7677aae82e185c63113f5d87df6edeef63/docs/config/lua/wezterm.url/Url.md (those docs will show up on the website within 20-60 minutes) It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer. Please take a few moments to try out the changes and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs. If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a If you are eager and can build from source then you may be able to try this out more quickly. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What Operating System(s) are you seeing this problem on?
Linux X11
Which Wayland compositor or X11 Window manager(s) are you using?
OS: Manjaro Linux x86_64
DE: Cinnamon
WM: Mutter (Muffin)
WezTerm version
wezterm 20230408-112425-69ae8472
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
valid character display.
It's been the same since I started using Wezterm. Any version.
I'm not in any trouble.
However, I would be happy to get a correctly encoded string.
Please let me know if there is any problem with my settings.
It's a low priority for me personally.
thank you.
$ mkdir '日本語文字列(multibytes)' && cd $_ mkdir: ディレクトリ '日本語文字列(multibytes)' を作成しました /tmp/RAMRAM/WORKING/日本語文字列(multibytes) zish 2023-07-15 17:03:20 /tmp/RAMRAM/WORKING/日本語文字列(multibytes)
To Reproduce
No response
Configuration
Expected Behavior
No response
Logs
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: